Thu Nov 2 13:21:03 CET 2006

Update of /home/cvs/otrs/bin
In directory lancelot:/tmp/cvs-serv11671/bin

Modified Files:
	CheckSum.pl Cron4Win32.pl CryptPassword.pl DeleteSessionIDs.pl 
	GenericAgent.pl PendingJobs.pl PostMasterDaemon.pl 
	PostMasterPOP3.pl RebuildTicketIndex.pl SetPermissions.sh 
	UnitTest.pl UnlockTickets.pl XMLMaster.pl 
	otrs.CreateNewTranslationFile otrs.addGroup otrs.addQueue 
	otrs.addStdResponse2Queue otrs.addUser otrs.addUser2Group 
	otrs.cleanup otrs.getConfig otrs.getGroupID 
	otrs.getTicketThread otrs.getUserID xml2sql.pl 
Log Message:
removed # --

Index: CheckSum.pl
===================================================================
RCS file: /home/cvs/otrs/bin/CheckSum.pl,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** CheckSum.pl	26 Aug 2006 17:22:05 -0000	1.4
--- CheckSum.pl	2 Nov 2006 12:20:59 -0000	1.5
***************
*** 40,46 ****
  my $Action = 'compare';
  my %Compare = ();
! # --
  # get options
- # --
  my %Opts = ();
  getopt('habd', \%Opts);
--- 40,45 ----
  my $Action = 'compare';
  my %Compare = ();
! 
  # get options
  my %Opts = ();
  getopt('habd', \%Opts);
***************
*** 131,133 ****
      }
  }
- 
--- 130,131 ----

Index: Cron4Win32.pl
===================================================================
RCS file: /home/cvs/otrs/bin/Cron4Win32.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** Cron4Win32.pl	31 Oct 2006 15:43:24 -0000	1.2
--- Cron4Win32.pl	2 Nov 2006 12:20:59 -0000	1.3
***************
*** 87,92 ****
  closedir(DATOUT);

- # --
- 
  1;
  }
\ No newline at end of file
--- 87,90 ----

Index: CryptPassword.pl
===================================================================
RCS file: /home/cvs/otrs/bin/CryptPassword.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** CryptPassword.pl	26 Aug 2006 17:26:11 -0000	1.2
--- CryptPassword.pl	2 Nov 2006 12:20:59 -0000	1.3
***************
*** 27,33 ****
  $VERSION =~ s/^\$.*:\W(.*)\W.+?$/$1/;

- # --
  # check args
- # --
  my $Password = shift;
  print "bin/CryptPassword.pl <Revision $VERSION> - to crypt database password for Kernel/Config.pm\n";
--- 27,31 ----

Index: DeleteSessionIDs.pl
===================================================================
RCS file: /home/cvs/otrs/bin/DeleteSessionIDs.pl,v
retrieving revision 1.17
retrieving revision 1.18
diff -C2 -r1.17 -r1.18
*** DeleteSessionIDs.pl	25 Sep 2006 13:25:30 -0000	1.17
--- DeleteSessionIDs.pl	2 Nov 2006 12:20:59 -0000	1.18
***************
*** 40,46 ****
  use Kernel::System::AuthSession;

- # --
  # common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 40,44 ----
***************
*** 57,69 ****
  );

- # --
  # check args
- # --
  my $Command = shift || '--help';
  print "DeleteSessionIDs.pl <Revision $VERSION> - delete all existing or expired session ids\n";
  print "Copyright (c) 2001-2006 OTRS GmbH, http://otrs.org/\n";
! # --
  # show/delete all session ids
- # -
  if (($Command eq '--all') || ($Command eq '--showall')) {
      print " Working on all session ids:\n";
--- 55,64 ----
  );

  # check args
  my $Command = shift || '--help';
  print "DeleteSessionIDs.pl <Revision $VERSION> - delete all existing or expired session ids\n";
  print "Copyright (c) 2001-2006 OTRS GmbH, http://otrs.org/\n";
! 
  # show/delete all session ids
  if (($Command eq '--all') || ($Command eq '--showall')) {
      print " Working on all session ids:\n";
***************
*** 82,88 ****
      exit (0);
  }
! # --
  # show/delete all expired session ids
- # --
  elsif (($Command eq '--expired') || ($Command eq '--showexpired')) {
      print " Working on expired session ids:\n";
--- 77,82 ----
      exit (0);
  }
! 
  # show/delete all expired session ids
  elsif (($Command eq '--expired') || ($Command eq '--showexpired')) {
      print " Working on expired session ids:\n";
***************
*** 115,121 ****
      exit (0);
  }
! # --
  # show usage
- # --
  else {
      print "usage: $0 [options] \n";
--- 109,114 ----
      exit (0);
  }
! 
  # show usage
  else {
      print "usage: $0 [options] \n";
***************
*** 128,131 ****
      exit (1);
  }
- # --
- 
--- 121,122 ----

Index: GenericAgent.pl
===================================================================
RCS file: /home/cvs/otrs/bin/GenericAgent.pl,v
retrieving revision 1.39
retrieving revision 1.40
diff -C2 -r1.39 -r1.40
*** GenericAgent.pl	26 Aug 2006 17:26:11 -0000	1.39
--- GenericAgent.pl	2 Nov 2006 12:20:59 -0000	1.40
***************
*** 108,114 ****
  }

- # --
  # process all jobs
- # --
  if ($Opts{'c'} eq 'db') {
      # create pid lock
--- 108,112 ----
***************
*** 194,200 ****
      $CommonObject{PIDObject}->PIDDelete(Name => 'GenericAgent');
  }
! # --
  # process all config file jobs
- # --
  else {
      foreach my $Job (sort keys %Jobs) {
--- 192,197 ----
      $CommonObject{PIDObject}->PIDDelete(Name => 'GenericAgent');
  }
! 
  # process all config file jobs
  else {
      foreach my $Job (sort keys %Jobs) {

Index: PendingJobs.pl
===================================================================
RCS file: /home/cvs/otrs/bin/PendingJobs.pl,v
retrieving revision 1.24
retrieving revision 1.25
diff -C2 -r1.24 -r1.25
*** PendingJobs.pl	25 Sep 2006 13:26:01 -0000	1.24
--- PendingJobs.pl	2 Nov 2006 12:20:59 -0000	1.25
***************
*** 43,49 ****
  use Kernel::System::State;

- # --
  # common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 43,47 ----
***************
*** 59,72 ****
  $CommonObject{StateObject} = Kernel::System::State->new(%CommonObject);

- # --
  # check args
- # --
  my $Command = shift || '--help';
  print "PendingJobs.pl <Revision $VERSION> - check pending tickets\n";
  print "Copyright (c) 2001-2006 OTRS GmbH, http://otrs.org/\n";

- # --
  # do ticket auto jobs
- # --
  my @PendingAutoStateIDs = $CommonObject{StateObject}->StateGetStatesByType(
      Type => 'PendingAuto',
--- 57,66 ----
***************
*** 110,116 ****
      }
  }
! # --
  # do ticket reminder notification jobs
- # --

  # get pending states
--- 104,109 ----
      }
  }
! 
  # do ticket reminder notification jobs

  # get pending states
***************
*** 160,166 ****
                  );
              }
-             # --
              # send reminder notification
-             # --
              print " Send reminder notification (TicketID=$_)\n";
              foreach (@UserID) {
--- 153,157 ----
***************
*** 199,201 ****

  exit (0);
- 
--- 190,191 ----

Index: PostMasterDaemon.pl
===================================================================
RCS file: /home/cvs/otrs/bin/PostMasterDaemon.pl,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -r1.9 -r1.10
*** PostMasterDaemon.pl	25 Sep 2006 13:32:08 -0000	1.9
--- PostMasterDaemon.pl	2 Nov 2006 12:20:59 -0000	1.10
***************
*** 64,73 ****
      Listen => 10,
  ) || die $@;
! # --
  for (1..$PreForkedServer) {
      MakeNewChild();
  }

- # --
  while (1) {
      sleep;
--- 64,72 ----
      Listen => 10,
  ) || die $@;
! 
  for (1..$PreForkedServer) {
      MakeNewChild();
  }

  while (1) {
      sleep;
***************
*** 77,81 ****
  }

- # --
  sub MakeNewChild {
      $Children++;
--- 76,79 ----
***************
*** 120,124 ****
  }

- # --
  sub StopChild {
      my $PID = wait;
--- 118,121 ----
***************
*** 127,137 ****
      delete $Children{$$};
  }
! # --
  sub PipeEmail {
      my @Email = @_;

-     # --
      # create common objects
-     # --
      my %CommonObject = ();
      $CommonObject{ConfigObject} = Kernel::Config->new();
--- 124,132 ----
      delete $Children{$$};
  }
! 
  sub PipeEmail {
      my @Email = @_;

      # create common objects
      my %CommonObject = ();
      $CommonObject{ConfigObject} = Kernel::Config->new();
***************
*** 162,164 ****
      }
  }
- 
--- 157,158 ----

Index: PostMasterPOP3.pl
===================================================================
RCS file: /home/cvs/otrs/bin/PostMasterPOP3.pl,v
retrieving revision 1.22
retrieving revision 1.23
diff -C2 -r1.22 -r1.23
*** PostMasterPOP3.pl	25 Sep 2006 13:33:20 -0000	1.22
--- PostMasterPOP3.pl	2 Nov 2006 12:20:59 -0000	1.23
***************
*** 43,49 ****
  use Kernel::System::POP3Account;

- # --
  # get options
- # --
  my %Opts = ();
  getopt('upshdf', \%Opts);
--- 43,47 ----
***************
*** 63,69 ****
      $Opts{'popd'} = 0;
  }
! # --
  # create common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 61,66 ----
      $Opts{'popd'} = 0;
  }
! 
  # create common objects
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
***************
*** 141,145 ****
  exit (0);

- # --
  sub FetchMail {
      my %Param = @_;
--- 138,141 ----
***************
*** 234,236 ****
      }
  }
- # --
--- 230,231 ----

Index: RebuildTicketIndex.pl
===================================================================
RCS file: /home/cvs/otrs/bin/RebuildTicketIndex.pl,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -r1.11 -r1.12
*** RebuildTicketIndex.pl	25 Sep 2006 13:34:07 -0000	1.11
--- RebuildTicketIndex.pl	2 Nov 2006 12:20:59 -0000	1.12
***************
*** 40,46 ****
  use Kernel::System::Ticket;

- # --
  # common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 40,44 ----
***************
*** 56,62 ****
  $CommonObject{TicketObject} = Kernel::System::Ticket->new(%CommonObject);

- # --
  # rebuild
- # --
  if ($CommonObject{TicketObject}->TicketAcceleratorRebuild()) {
      exit;
--- 54,58 ----
***************
*** 66,68 ****
      exit 1;
  }
- 
--- 62,63 ----

Index: SetPermissions.sh
===================================================================
RCS file: /home/cvs/otrs/bin/SetPermissions.sh,v
retrieving revision 1.28
retrieving revision 1.29
diff -C2 -r1.28 -r1.29
*** SetPermissions.sh	3 Oct 2006 14:36:02 -0000	1.28
--- SetPermissions.sh	2 Nov 2006 12:20:59 -0000	1.29
***************
*** 25,31 ****

  if ! test $1 || ! test $2 || ! test $3; then
-     # --
      # check required options
-     # --
      echo ""
      echo "Usage: SetPermissions.sh <OTRS_HOME> <OTRS_USER> <WEBSERVER_USER> [OTRS_GROUP] [WEB_GROUP]"
--- 25,29 ----
***************
*** 35,41 ****
      exit 1;
  else
-     # --
      # system settings
-     # --
      WEBUSER=$3
      OTRSUSER=$2
--- 33,37 ----
***************
*** 47,54 ****
  fi

- 
- # --
  # set permission
- # --
  echo "Setting file permissions... "
  # set all files writeabel for webserver user (needed for package manager)
--- 43,47 ----
***************
*** 94,100 ****
  fi

- # --
  # var/*
! # --
  # set the var directory to OTRS and webserver user
  echo "chown -R $OTRSUSER:$WEBGROUP $OTRSDEST/var/"
--- 87,92 ----
  fi

  # var/*
! 
  # set the var directory to OTRS and webserver user
  echo "chown -R $OTRSUSER:$WEBGROUP $OTRSDEST/var/"
***************
*** 114,120 ****
  chmod 664 $OTRSDEST/var/log/TicketCounter.log

! # --
  # bin/*
! # --
  # set all bin/* as executable
  echo "chmod -R 775 $OTRSDEST/bin/"
--- 106,112 ----
  chmod 664 $OTRSDEST/var/log/TicketCounter.log

! 
  # bin/*
! 
  # set all bin/* as executable
  echo "chmod -R 775 $OTRSDEST/bin/"

Index: UnitTest.pl
===================================================================
RCS file: /home/cvs/otrs/bin/UnitTest.pl,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -r1.7 -r1.8
*** UnitTest.pl	26 Aug 2006 17:26:11 -0000	1.7
--- UnitTest.pl	2 Nov 2006 12:20:59 -0000	1.8
***************
*** 41,47 ****
  use Kernel::System::Main;

- # --
  # get options
- # --
  my %Opts = ();
  getopt('hqtdno', \%Opts);
--- 41,45 ----
***************
*** 52,58 ****
      exit 1;
  }
! # --
  # create common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 50,55 ----
      exit 1;
  }
! 
  # create common objects
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();

Index: UnlockTickets.pl
===================================================================
RCS file: /home/cvs/otrs/bin/UnlockTickets.pl,v
retrieving revision 1.23
retrieving revision 1.24
diff -C2 -r1.23 -r1.24
*** UnlockTickets.pl	25 Sep 2006 13:34:46 -0000	1.23
--- UnlockTickets.pl	2 Nov 2006 12:20:59 -0000	1.24
***************
*** 46,52 ****
  my $Debug = 0;

- # --
  # common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 46,50 ----
***************
*** 69,81 ****
  my @ViewableLockIDs = $CommonObject{LockObject}->LockViewableLock(Type => 'ID');

- # --
  # check args
- # --
  my $Command = shift || '--help';
  print "UnlockTickets.pl <Revision $VERSION> - unlock tickets\n";
  print "Copyright (c) 2001-2006 OTRS GmbH, http//otrs.org/\n";
! # --
  # unlock all tickets
- # --
  if ($Command eq '--all') {
      print " Unlock all tickets:\n";
--- 67,76 ----
  my @ViewableLockIDs = $CommonObject{LockObject}->LockViewableLock(Type => 'ID');

  # check args
  my $Command = shift || '--help';
  print "UnlockTickets.pl <Revision $VERSION> - unlock tickets\n";
  print "Copyright (c) 2001-2006 OTRS GmbH, http//otrs.org/\n";
! 
  # unlock all tickets
  if ($Command eq '--all') {
      print " Unlock all tickets:\n";
***************
*** 107,113 ****
      exit (0);
  }
! # --
  # unlock old tickets
- # --
  elsif ($Command eq '--timeout') {
      print " Unlock old tickets:\n";
--- 102,107 ----
      exit (0);
  }
! 
  # unlock old tickets
  elsif ($Command eq '--timeout') {
      print " Unlock old tickets:\n";
***************
*** 153,159 ****
      exit (0);
  }
! # --
  # show usage
- # --
  else {
      print "usage: $0 [options] \n";
--- 147,152 ----
      exit (0);
  }
! 
  # show usage
  else {
      print "usage: $0 [options] \n";
***************
*** 164,166 ****
      exit (1);
  }
- 
--- 157,158 ----

Index: XMLMaster.pl
===================================================================
RCS file: /home/cvs/otrs/bin/XMLMaster.pl,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** XMLMaster.pl	25 Sep 2006 13:35:29 -0000	1.4
--- XMLMaster.pl	2 Nov 2006 12:20:59 -0000	1.5
***************
*** 41,47 ****
  use Kernel::System::XMLMaster;

- # --
  # get options
- # --
  my %Opts = ();
  getopt('hqtd', \%Opts);
--- 41,45 ----
***************
*** 56,62 ****
  }

- # --
  # create common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 54,58 ----

Index: otrs.CreateNewTranslationFile
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.CreateNewTranslationFile,v
retrieving revision 1.14
retrieving revision 1.15
diff -C2 -r1.14 -r1.15
*** otrs.CreateNewTranslationFile	26 Aug 2006 17:22:05 -0000	1.14
--- otrs.CreateNewTranslationFile	2 Nov 2006 12:20:59 -0000	1.15
***************
*** 39,56 ****
  use Kernel::Language;

- # --
  # get opts
- # --
  getopt('olst',  \%Opts);
! # --
  # print head
- # --
  print "otrs.CreateNewTranslationFile <Revision $VERSION> - create new translation file\n";
  print "Copyright (c) 2001-2006 OTRS GmbH, http://otrs.org/\n";
  print "usage: otrs.CreateNewTranslationFile -l <Language> -t <dtl_files_or_directory>\n";

- # --
  # common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 39,51 ----
  use Kernel::Language;

  # get opts
  getopt('olst',  \%Opts);
! 
  # print head
  print "otrs.CreateNewTranslationFile <Revision $VERSION> - create new translation file\n";
  print "Copyright (c) 2001-2006 OTRS GmbH, http://otrs.org/\n";
  print "usage: otrs.CreateNewTranslationFile -l <Language> -t <dtl_files_or_directory>\n";

  # common objects
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
***************
*** 62,68 ****
      %CommonObject,
  );
! # --
  # check params
- # --
  if (!$Opts{'l'}) {
      print "ERROR: -l <Language>!\n";
--- 57,62 ----
      %CommonObject,
  );
! 
  # check params
  if (!$Opts{'l'}) {
      print "ERROR: -l <Language>!\n";
***************
*** 94,100 ****
  }

- # --
  # common objects
- # --
  $CommonObject{LanguageObject} = Kernel::Language->new(
      %CommonObject,
--- 88,92 ----
***************
*** 103,109 ****
  );

- # --
  # open .dtl files and write new translation file
- # --
  my $Data = '';
  my %UsedWords = ();
--- 95,99 ----
***************
*** 192,198 ****
      }
  }
! # --
  # open old translation file
- # --
  my %MetaData = ();
  my $NewOut = '';
--- 182,187 ----
      }
  }
! 
  # open old translation file
  my %MetaData = ();
  my $NewOut = '';

Index: otrs.addGroup
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.addGroup,v
retrieving revision 1.10
retrieving revision 1.11
diff -C2 -r1.10 -r1.11
*** otrs.addGroup	3 Oct 2006 14:36:02 -0000	1.10
--- otrs.addGroup	2 Nov 2006 12:20:59 -0000	1.11
***************
*** 51,57 ****
  }

- # --
  # create common objects
- # --
  $CommonObject{ConfigObject} = Kernel::Config->new();
  $CommonObject{LogObject}    = Kernel::System::Log->new(%CommonObject, LogPrefix => 'otrs.addGroup');
--- 51,55 ----

Index: otrs.addQueue
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.addQueue,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -r1.9 -r1.10
*** otrs.addQueue	3 Oct 2006 14:36:02 -0000	1.9
--- otrs.addQueue	2 Nov 2006 12:20:59 -0000	1.10
***************
*** 42,48 ****
  use Kernel::System::Group;

- # --
  # get options
- # --
  my %Opts = ();
  getopt('hgnsc', \%Opts);
--- 42,46 ----
***************
*** 64,70 ****
  }

- # --
  # create common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new(%CommonObject);
--- 62,66 ----

Index: otrs.addStdResponse2Queue
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.addStdResponse2Queue,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -r1.8 -r1.9
*** otrs.addStdResponse2Queue	23 Jan 2003 22:50:09 -0000	1.8
--- otrs.addStdResponse2Queue	2 Nov 2006 12:20:59 -0000	1.9
***************
*** 26,34 ****
  use Kernel::System::Queue;

! 
! # --
! # create common objects 
! # --
! 
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new(%CommonObject);
--- 26,30 ----
  use Kernel::System::Queue;

! # create common objects
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new(%CommonObject);
***************
*** 37,48 ****
  $CommonObject{QueueObject}  = Kernel::System::Queue->new(%CommonObject);

- 
- 
- 
- 
- 
- 
- 
- 
  my %Param;
  undef %Param;
--- 33,36 ----
***************
*** 51,55 ****
  $Param{UserID}='1';

- 
  #Validrecord
  $Param{ValidID}='1';
--- 39,42 ----
***************
*** 59,63 ****

!    
  $CommonObject{QueueObject}->SetQueueStdResponse(%Param);
  exit (0);
--- 46,50 ----

! 
  $CommonObject{QueueObject}->SetQueueStdResponse(%Param);
  exit (0);

Index: otrs.addUser
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.addUser,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -r1.8 -r1.9
*** otrs.addUser	6 Mar 2003 22:11:59 -0000	1.8
--- otrs.addUser	2 Nov 2006 12:20:59 -0000	1.9
***************
*** 32,39 ****
  use Kernel::System::User;

! # --
! # create common objects 
! # --
! 
  my %CommonObject = ();
  $CommonObject{ConfigObject}  = Kernel::Config->new(%CommonObject);
--- 32,36 ----
  use Kernel::System::User;

! # create common objects
  my %CommonObject = ();
  $CommonObject{ConfigObject}  = Kernel::Config->new(%CommonObject);
***************
*** 66,76 ****
     import  Kernel::System::Group;
     $CommonObject{GroupObject}   = Kernel::System::Group->new(%CommonObject);
!    
!    
     $Param{Group}=$opts{'g'};
!    
     if ($Param{GID}=$CommonObject{GroupObject}->GetGroupIdByName(%Param)){
          print "Found Group.. GID is $Param{GID}" , "\n";
!    } 
     else {
          print "Failed to get Group ID. Perhaps non-existent group..\n";
--- 63,73 ----
     import  Kernel::System::Group;
     $CommonObject{GroupObject}   = Kernel::System::Group->new(%CommonObject);
! 
! 
     $Param{Group}=$opts{'g'};
! 
     if ($Param{GID}=$CommonObject{GroupObject}->GetGroupIdByName(%Param)){
          print "Found Group.. GID is $Param{GID}" , "\n";
!    }
     else {
          print "Failed to get Group ID. Perhaps non-existent group..\n";
***************
*** 78,82 ****
     if ($CommonObject{GroupObject}->GroupMemberAdd(%Param)) {
          print "User added to group\n";
!    } 
     else {
          print "Failed to add user to group\n";
--- 75,79 ----
     if ($CommonObject{GroupObject}->GroupMemberAdd(%Param)) {
          print "User added to group\n";
!    }
     else {
          print "Failed to add user to group\n";
***************
*** 84,87 ****
  }

- # --
  exit (0);
--- 81,83 ----

Index: otrs.addUser2Group
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.addUser2Group,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -r1.11 -r1.12
*** otrs.addUser2Group	3 Oct 2006 14:36:02 -0000	1.11
--- otrs.addUser2Group	2 Nov 2006 12:20:59 -0000	1.12
***************
*** 59,65 ****
  }

- # --
  # create common objects
- # --
  $CommonObject{ConfigObject} = Kernel::Config->new(%CommonObject);
  $CommonObject{LogObject}    = Kernel::System::Log->new(%CommonObject, LogPrefix => 'otrs.addUser2Group');
--- 59,63 ----

Index: otrs.cleanup
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.cleanup,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** otrs.cleanup	26 Aug 2006 17:22:05 -0000	1.2
--- otrs.cleanup	2 Nov 2006 12:20:59 -0000	1.3
***************
*** 30,36 ****
  fi

- # --
  # check otrs spool dir
- # --
  echo " Checking otrs spool dir... "
  for i in $OTRS_SPOOLDIR/* ; do
--- 30,34 ----

Index: otrs.getConfig
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.getConfig,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -r1.7 -r1.8
*** otrs.getConfig	26 Aug 2006 17:22:05 -0000	1.7
--- otrs.getConfig	2 Nov 2006 12:20:59 -0000	1.8
***************
*** 34,40 ****
  use Kernel::System::Log;

- # --
  # common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 34,38 ----
***************
*** 43,49 ****
      %CommonObject,
  );
! # --
  # print wanted var
- # --
  my $Key = shift || '';
  if ($Key) {
--- 41,46 ----
      %CommonObject,
  );
! 
  # print wanted var
  my $Key = shift || '';
  if ($Key) {
***************
*** 66,89 ****
  }
  else {
-     # --
      # print all vars
-     # --
      foreach (sort keys %{$CommonObject{ConfigObject}}) {
!       print $_.":";
!       if (ref($CommonObject{ConfigObject}->{$_}) eq 'ARRAY') {
!         foreach (@{$CommonObject{ConfigObject}->{$_}}) {
!             print "$_;";
          }
!         print "\n";
!       }
!       elsif (ref($CommonObject{ConfigObject}->{$_}) eq 'HASH') {
!         foreach my $Key (sort keys %{$CommonObject{ConfigObject}->{$_}}) {
!             print "$Key=$CommonObject{ConfigObject}->{$_}->{$Key};";
          }
-         print "\n";
-       }
-       else {
-         print $CommonObject{ConfigObject}->{$_}."\n";
-       }
      }
  }
--- 63,84 ----
  }
  else {
      # print all vars
      foreach (sort keys %{$CommonObject{ConfigObject}}) {
!         print $_.":";
!         if (ref($CommonObject{ConfigObject}->{$_}) eq 'ARRAY') {
!             foreach (@{$CommonObject{ConfigObject}->{$_}}) {
!                 print "$_;";
!             }
!             print "\n";
          }
!         elsif (ref($CommonObject{ConfigObject}->{$_}) eq 'HASH') {
!             foreach my $Key (sort keys %{$CommonObject{ConfigObject}->{$_}}) {
!                 print "$Key=$CommonObject{ConfigObject}->{$_}->{$Key};";
!             }
!             print "\n";
!         }
!         else {
!             print $CommonObject{ConfigObject}->{$_}."\n";
          }
      }
  }

Index: otrs.getGroupID
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.getGroupID,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -r1.6 -r1.7
*** otrs.getGroupID	23 Jan 2003 22:50:09 -0000	1.6
--- otrs.getGroupID	2 Nov 2006 12:20:59 -0000	1.7
***************
*** 26,33 ****
  use Kernel::System::Group;

! # --
! # create common objects 
! # --
! 
  my %CommonObject = ();
  $CommonObject{ConfigObject}  = Kernel::Config->new(%CommonObject);
--- 26,30 ----
  use Kernel::System::Group;

! # create common objects
  my %CommonObject = ();
  $CommonObject{ConfigObject}  = Kernel::Config->new(%CommonObject);
***************
*** 36,41 ****
  $CommonObject{GroupObject}   = Kernel::System::Group->new(%CommonObject);

- 
- 
  my %Param;
  undef %Param;
--- 33,36 ----
***************
*** 43,52 ****
  #user id of the person making the query
  $Param{UserID}='1';
- 
- 
- 
  $Param{Group}=$ARGV[0];

- 
  if (my $gid=$CommonObject{GroupObject}->GetGroupIdByName(%Param)){
     print $gid , "\n";
--- 38,43 ----
***************
*** 54,57 ****
     print "Failed to get Group ID. Perhaps non-existent group..\n";
  }
! # --
  exit (0);
--- 45,48 ----
     print "Failed to get Group ID. Perhaps non-existent group..\n";
  }
! 
  exit (0);

Index: otrs.getTicketThread
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.getTicketThread,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -r1.6 -r1.7
*** otrs.getTicketThread	26 Aug 2006 17:22:05 -0000	1.6
--- otrs.getTicketThread	2 Nov 2006 12:20:59 -0000	1.7
***************
*** 40,46 ****
  use Kernel::System::User;

- # --
  # common objects
- # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 40,44 ----
***************
*** 75,77 ****
      print "$Article{Body}\n";
      print "---------------------------------------------------------------------\n";
! } 
--- 73,75 ----
      print "$Article{Body}\n";
      print "---------------------------------------------------------------------\n";
! }

Index: otrs.getUserID
===================================================================
RCS file: /home/cvs/otrs/bin/otrs.getUserID,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -r1.7 -r1.8
*** otrs.getUserID	28 Feb 2006 05:55:09 -0000	1.7
--- otrs.getUserID	2 Nov 2006 12:20:59 -0000	1.8
***************
*** 28,34 ****
  use Kernel::System::User;

! # --
! # create common objects 
! # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new(%CommonObject);
--- 28,32 ----
  use Kernel::System::User;

! # create common objects
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new(%CommonObject);
***************
*** 37,42 ****
  $CommonObject{UserObject}   = Kernel::System::User->new(%CommonObject);

- 
- 
  my %Param = ();

--- 35,38 ----

Index: xml2sql.pl
===================================================================
RCS file: /home/cvs/otrs/bin/xml2sql.pl,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -r1.7 -r1.8
*** xml2sql.pl	25 Sep 2006 13:37:20 -0000	1.7
--- xml2sql.pl	2 Nov 2006 12:20:59 -0000	1.8
***************
*** 63,69 ****
  }

- # --
  # create common objects
! # --
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
--- 63,68 ----
  }

  # create common objects
! 
  my %CommonObject = ();
  $CommonObject{ConfigObject} = Kernel::Config->new();
***************
*** 129,131 ****
      close (OUT);
  }
- 
--- 128,129 ----