[otrs-cvs] otrs/Kernel/Modules AgentTicketEmail.pm, 1.54,
1.55 AgentTicketPhone.pm, 1.62, 1.63
cvs-log at otrs.org
cvs-log at otrs.org
Tue Apr 1 14:53:55 GMT 2008
Comments:
Update of /home/cvs/otrs/Kernel/Modules
In directory lancelot:/tmp/cvs-serv14487
Modified Files:
AgentTicketEmail.pm AgentTicketPhone.pm
Log Message:
- Fixed bug#2453: syntax errors on customer search; name at host problems
the check fails if the value in the from field is not fully rfc 2822
compilant.
Author: ak
Index: AgentTicketEmail.pm
===================================================================
RCS file: /home/cvs/otrs/Kernel/Modules/AgentTicketEmail.pm,v
retrieving revision 1.54
retrieving revision 1.55
diff -C2 -d -r1.54 -r1.55
*** AgentTicketEmail.pm 31 Mar 2008 22:18:37 -0000 1.54
--- AgentTicketEmail.pm 1 Apr 2008 14:53:50 -0000 1.55
***************
*** 503,507 ****
--- 503,512 ----
for (qw(To Cc Bcc)) {
if ( $GetParam{$_} ) {
+ EMAIL:
for my $Email ( Mail::Address->parse( $GetParam{$_} ) ) {
+ # skip check if the email address is not fully RFC 2822 compilant
+ next EMAIL if !$Email->host();
+ next EMAIL if !$Email->user();
+
if ( !$Self->{CheckItemObject}->CheckEmail( Address => $Email->address() ) ) {
$Error{"$_ invalid"} .= $Self->{CheckItemObject}->CheckError();
Author: ak
Index: AgentTicketPhone.pm
===================================================================
RCS file: /home/cvs/otrs/Kernel/Modules/AgentTicketPhone.pm,v
retrieving revision 1.62
retrieving revision 1.63
diff -C2 -d -r1.62 -r1.63
*** AgentTicketPhone.pm 31 Mar 2008 22:18:37 -0000 1.62
--- AgentTicketPhone.pm 1 Apr 2008 14:53:50 -0000 1.63
***************
*** 537,542 ****
}
! # check some values
for my $Email ( Mail::Address->parse( $GetParam{From} ) ) {
if ( !$Self->{CheckItemObject}->CheckEmail( Address => $Email->address() ) ) {
$Error{"From invalid"} .= $Self->{CheckItemObject}->CheckError();
--- 537,547 ----
}
! # check email address
! EMAIL:
for my $Email ( Mail::Address->parse( $GetParam{From} ) ) {
+ # skip check if the email address is not fully RFC 2822 compilant
+ next EMAIL if !$Email->host();
+ next EMAIL if !$Email->user();
+
if ( !$Self->{CheckItemObject}->CheckEmail( Address => $Email->address() ) ) {
$Error{"From invalid"} .= $Self->{CheckItemObject}->CheckError();
More information about the cvs-log
mailing list