[otrs-cvs] otrs/Kernel/System/AuthSession DB.pm,1.33,1.34

CVS commits notifications of OTRS.org cvs-log at otrs.org
Fri Apr 25 10:33:37 GMT 2008


Comments:
Update of /home/cvs/otrs/Kernel/System/AuthSession
In directory lancelot:/tmp/cvs-serv32585/Kernel/System/AuthSession

Modified Files:
	DB.pm 
Log Message:
Removed brackets from push() functions and simplify code for a better readability.

Author: tr

Index: DB.pm
===================================================================
RCS file: /home/cvs/otrs/Kernel/System/AuthSession/DB.pm,v
retrieving revision 1.33
retrieving revision 1.34
diff -C2 -d -r1.33 -r1.34
*** DB.pm	18 Mar 2008 16:10:41 -0000	1.33
--- DB.pm	25 Apr 2008 10:33:32 -0000	1.34
***************
*** 62,71 ****
      # check session id
      if ( !$Param{SessionID} ) {
!         $Self->{LogObject}->Log( Priority => 'error', Message => "Got no SessionID!!" );
          return;
      }
  
      # set default message
!     $Self->{CheckSessionIDMessage} = "SessionID is invalid!!!";
  
      # session id check
--- 62,71 ----
      # check session id
      if ( !$Param{SessionID} ) {
!         $Self->{LogObject}->Log( Priority => 'error', Message => 'Got no SessionID!!' );
          return;
      }
  
      # set default message
!     $Self->{CheckSessionIDMessage} = 'SessionID is invalid!!!';
  
      # session id check
***************
*** 73,77 ****
  
      if ( !$Data{UserID} || !$Data{UserLogin} ) {
!         $Self->{CheckSessionIDMessage} = "SessionID invalid! Need user data!";
          $Self->{LogObject}->Log(
              Priority => 'notice',
--- 73,77 ----
  
      if ( !$Data{UserID} || !$Data{UserLogin} ) {
!         $Self->{CheckSessionIDMessage} = 'SessionID invalid! Need user data!';
          $Self->{LogObject}->Log(
              Priority => 'notice',
***************
*** 149,153 ****
      # check session id
      if ( !$Param{SessionID} ) {
!         $Self->{LogObject}->Log( Priority => 'error', Message => "Got no SessionID!!" );
          return;
      }
--- 149,153 ----
      # check session id
      if ( !$Param{SessionID} ) {
!         $Self->{LogObject}->Log( Priority => 'error', Message => 'Got no SessionID!!' );
          return;
      }
***************
*** 213,217 ****
      my $DataToStore = '';
      for ( keys %Param ) {
!         if ( defined( $Param{$_} ) ) {
              $Self->{EncodeObject}->EncodeOutput( \$Param{$_} );
              $DataToStore .= "$_:" . encode_base64( $Param{$_}, '' ) . ":;";
--- 213,217 ----
      my $DataToStore = '';
      for ( keys %Param ) {
!         if ( defined $Param{$_} ) {
              $Self->{EncodeObject}->EncodeOutput( \$Param{$_} );
              $DataToStore .= "$_:" . encode_base64( $Param{$_}, '' ) . ":;";
***************
*** 237,241 ****
      # check session id
      if ( !$Param{SessionID} ) {
!         $Self->{LogObject}->Log( Priority => 'error', Message => "Got no SessionID!!" );
          return;
      }
--- 237,241 ----
      # check session id
      if ( !$Param{SessionID} ) {
!         $Self->{LogObject}->Log( Priority => 'error', Message => 'Got no SessionID!!' );
          return;
      }
***************
*** 306,310 ****
      # reset cache
      if ( $Self->{"Cache::$Param{SessionID}"} ) {
!         delete( $Self->{"Cache::$Param{SessionID}"} );
      }
      return 1;
--- 306,310 ----
      # reset cache
      if ( $Self->{"Cache::$Param{SessionID}"} ) {
!         delete $Self->{"Cache::$Param{SessionID}"};
      }
      return 1;
***************
*** 321,325 ****
      );
      while ( my @Row = $Self->{DBObject}->FetchrowArray() ) {
!         push( @SessionIDs, $Row[0] );
      }
      return @SessionIDs;
--- 321,325 ----
      );
      while ( my @Row = $Self->{DBObject}->FetchrowArray() ) {
!         push @SessionIDs, $Row[0];
      }
      return @SessionIDs;


More information about the cvs-log mailing list