Carlos
Thank you I'm already familiar with the guidelines since I was very active in the community back in 2006-8 when I maintained and developed an instance of OTRS for a stock exchange. That said I'll look it over to see if any thing other than the ability to submit via Github pull request has changed.
You should expect to see some of my patches in the next couple of days. I hope people like them.
-- Sent from my HP Pre3
On Jan 6, 2014 17:33, Carlos RodrÃguez <carlos.rodriguez@otrs.com> wrote:
Hi Paul,
You as any other contributor is very welcome to send improvements in the code, thank you!
Following this guide lines will make easier and faster to integrate your contributions.
((enjoy))
Carlos RodrÃguez
hello every one
Its been quite a few years since I was on this list. Im working now at
an other company where we are implementing OTRS. I have been looking
over the code and there has been a lot of progress since I last looked
at it.
That said there are a few things that struck me as inefficient and not
as flexible as I would like in Kernel/System/TemplateGenerator.pm
Ill be signing the contributors agreement shortly and will do a fork
with a push request on github shortly but I wanted to gauge some of
the reactions to what I want to submit before I go to far with it.
essentially what I would like to change is the handleing of tags like
<OTRS_CUSTOMER_SUBJECT[20]> and <OTRS_CUSTOMER_EMAIL[5]>
I found an inefficiency in the handling of <OTRS_CUSTOMER_EMAIL[5]>
specificly if you set say
<OTRS_CUSTOMER_EMAIL[99999999999999999999999999999999]> there is an
inefficiency in the loop which is easy to fix with a precheck which
I've already written.
additionally Ive also made a change where <OTRS_CUSTOMER_EMAIL[]>
<OTRS_CUSTOMER_EMAIL> are treated as inset the whole message.
the changes I made only added a few lines and a very slight
modification to the regex used to match and replace it.
I also modified the handling of <OTRS_CUSTOMER_SUBJECT[20]> to work
in a similar manner. and made it so if the length of the subject isn't
longer than the number of characters specified it will not add the "
[...]" suffix to the subject.
this was handled by a slight tweak of the regex and the addition of an
if statement.
What I would like to do eventually is make this functionality a simple
set of methods (OO speak for functions) which can be called to handle
this for any of these template replace tags as efficiently as
possible. we would need more than two because of things like the
custom fields. I'm fairly sure I could be handled with just a few
methods simple to use methods and I could make the code far more
efficient in the process the data.
Does any one have any comment, suggestions, or requests on this before
I get too deep into writing it?
Thank You
Paul Robert Marino
_______________________________________________
OTRS mailing list: dev - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/dev
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev