Re: [dev] Unused code?

4 Nov 2014

      Hi Moritz,

I’ve also found that part of the code, and have the same question, I’m not sure but it might be there because of a feature add on or so, you can’t set this preference to 2 in the GUI, but there are alternative ways to set the value.

In my eyes i would remove it, but i’m afraid it affect some obscure parts.

((enjoy))

Carlos Rodríguez
...
On Nov 4, 2014, at 5:33 AM, Moritz Lenz  wrote:
Hi all,
Here:
https://github.com/OTRS/otrs/blob/bc9684d6e8baad693a8dada859b8f20af6cbcfff/K...
In Kernel::System::Ticket::Article there is this code:
if (
                   $UserData{UserSendFollowUpNotification}
                   && $UserData{UserSendFollowUpNotification} == 2
                   && $Ticket{OwnerID} ne 1
                   && $Ticket{OwnerID} ne $Param{UserID}
                   && $Ticket{OwnerID} ne $UserData{UserID}
                   )
               {
However the default preferences only allow UserSendFollowUpNotification to be 0 or 1 (or undef when not set).
Is this some undocumented feature? Or simply dead code that can be removed?
The code seems to come from 2005 originally: https://github.com/OTRS/otrs/commit/777b9c8225aeffd90bb7b3cef012cdd2ecbf798b
_______________________________________________
OTRS mailing list: dev - Webpage: http://otrs.org/
Archive: http://lists.otrs.org/pipermail/dev
To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev