Re: [dev] hello again every one Im back and have code to contribute

Hi Paul, You as any other contributor is very welcome to send improvements in the code, thank you! As a suggestion please take a look at the OTRS Development Manual, specially in the code style guide http://doc.otrs.org/developer/3.3/en/html/code-style-guide.html Following this guide lines will make easier and faster to integrate your contributions. ((enjoy)) Carlos Rodríguez On Jan 6, 2014, at 4:05 PM, Paul Robert Marino wrote:

hello every one Its been quite a few years since I was on this list. Im working now at an other company where we are implementing OTRS. I have been looking over the code and there has been a lot of progress since I last looked at it. That said there are a few things that struck me as inefficient and not as flexible as I would like in Kernel/System/TemplateGenerator.pm

Ill be signing the contributors agreement shortly and will do a fork with a push request on github shortly but I wanted to gauge some of the reactions to what I want to submit before I go to far with it.

essentially what I would like to change is the handleing of tags like and

I found an inefficiency in the handling of specificly if you set say there is an inefficiency in the loop which is easy to fix with a precheck which I've already written. additionally Ive also made a change where are treated as inset the whole message. the changes I made only added a few lines and a very slight modification to the regex used to match and replace it.

I also modified the handling of to work in a similar manner. and made it so if the length of the subject isn't longer than the number of characters specified it will not add the " [...]" suffix to the subject. this was handled by a slight tweak of the regex and the addition of an if statement.

What I would like to do eventually is make this functionality a simple set of methods (OO speak for functions) which can be called to handle this for any of these template replace tags as efficiently as possible. we would need more than two because of things like the custom fields. I'm fairly sure I could be handled with just a few methods simple to use methods and I could make the code far more efficient in the process the data.

Does any one have any comment, suggestions, or requests on this before I get too deep into writing it?

Thank You Paul Robert Marino _______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev