[dev] German version of CLA: dev Digest, Vol 34, Issue 8

Hi Martin, thanks for your response.

...

why specifically do you think that a German version would be needed in addition to the already available English version? (I'm not on facebook.)

When you have German-speaking contributors, then it's of course irrelevant in which language do they contribute. I already mentioned in my last email the reason and argumentation for a German translation: the language gets relevant, when a jurisdiction issue appears (German courts clearly prefer to have documentation in German). If - for example - capeIT as a code contributor would like to contribute in the sense of the mentioned CLA, then it would be really nice to have the German jurisdiction in the case "something went terribly wrong and we need an juridical settlement". As far as everything goes well, there is no need to involve any court, but what if not? Additionally, AFAIK, the most contributors and active community members come indeed from the German-speaking area. The OTRS Community Board (Otterhub) is also a German association that was used to be supported by among all OTRS GmbH (and later by OTRS AG). Then, the already mentioned OTRS Package Archive (OPAR, browseable collection of plugins for the popular OTRS software) was created and has been managed by a German community member Renée Bäcker. Then again, the OTRS AG is a German company (OTRS AG Bad Homburg, Norsk-Data-Str. 1, 61352 Bad Homburg). Finally, it would be really nice gesture to get the CLA in German and honestly, it's not the biggest effort to translate the document. If OTRS AG doesn't have time or other resources to translate it, someone else could do it within the community work. Therefore two questions: 1) can we expect the translation (if yes, when) 2) and if not, will OTRS AG accept the German CLA's translation made by community with the same impact as the English version? If not, then the community work doesn't really make sense.   Thanks in advance for your answer. Hope to hear from you soon,   Kind reagrds, Anna Brakoniecka   ** With KIX4OTRS... one step ahead in service ** ** http://www.cape-it.de/kix4otrs-standard-features.html ** ** http://www.cape-it.de/references.html **   Anna Brakoniecka c.a.p.e. IT® GmbH - ...cape it easy Annaberger Str. 240, D-09125 Chemnitz http://www.cape-it.de Tel: +49 371 5347 620 Fax: +49 371 5347 625 AG Chemnitz - HRB 23192 Geschäftsführer Rico Barth, Thomas Maier     -----Ursprüngliche Nachricht----- Von:dev-request@otrs.org Gesendet:Mo 13.01.2014 13:00 Betreff:dev Digest, Vol 34, Issue 8 An:dev@otrs.org; Send dev mailing list submissions to dev@otrs.org To subscribe or unsubscribe via the World Wide Web, visit http://lists.otrs.org/cgi-bin/listinfo/dev or, via email, send a message with subject or body 'help' to dev-request@otrs.org You can reach the person managing the list at dev-owner@otrs.org When replying, please edit your Subject line so it is more specific than "Re: Contents of dev digest..." Today's Topics:   1. Re: Question related to code contribution :: dev Digest, Vol      34, Issue 5 (Martin Gruner)   2. Re: Upgrading password hashes (Martin Gruner) ---------------------------------------------------------------------- Message: 1 Date: Mon, 13 Jan 2014 08:51:20 +0100 From: Martin Gruner Subject: Re: [dev] Question related to code contribution :: dev Digest, Vol 34, Issue 5 To: Development community of OTRS Message-ID: <52D39AF8.2060305@otrs.com> Content-Type: text/plain; charset=ISO-8859-1 Hi Anna, why specifically do you think that a German version would be needed in addition to the already available English version? (I'm not on facebook.) In general, I'm open to the suggestion, but I don't believe we'll translate the CLA to all contributor's languages. Regards, mg Am 08.01.14 14:13, schrieb Anna Brakoniecka:

Hello,

 

due to the mentioned issue of code contribution, I have a question related to it. Torsten Thau put the question already in the OTRS Facebook group, but there is no answer yet, even if some weeks passed by. The answer is important for (among all) me, because capeIT has been contributing to the OTRS-project for years

 

  * by delivering bug fixes, code, free additional modules     (ImportExportExtensions, ITSMAttributeCollection, KIX4OTRS,     ConfigureCallHome, etc., the complete list at     http://www.cape-it.de/free-otrs-community-additional-modules.html     and OPAR http://opar.perl-services.de/package/author/CAPEIT )

 

  * and community work (among all our input in the OTRS forum and     mailing lists).

 

*My question:* is there a chance of getting the Contributor License Agreement in German? Until now, the document is only in English. The German aspect is important due to the German jurisdiction that would be relevant for German-speaking code contributors.  

Is there any answer, I could get to this question? Thanks in advance for any hint. Even a pure "No" would be already helpful.

Kind regards, Anna Brakoniecka

 

** With KIX4OTRS... one step ahead in service ** ** http://www.cape-it.de/kix4otrs-standard-features.html ** ** http://www.cape-it.de/references.html **  

Anna Brakoniecka

c.a.p.e. IT? GmbH - ...cape it easy Annaberger Str. 240, D-09125 Chemnitz http://www.cape-it.de Tel: +49 371 5347 620 Fax: +49 371 5347 625 AG Chemnitz - HRB 23192 Gesch?ftsf?hrer Rico Barth, Thomas Maier

 

 

    -----Urspr?ngliche Nachricht-----     *Von:*dev-request@otrs.org     *Gesendet:*Di 07.01.2014 12:57     *Betreff:*dev Digest, Vol 34, Issue 5     *An:*dev@otrs.org;     Send dev mailing list submissions to     dev@otrs.org

    To subscribe or unsubscribe via the World Wide Web, visit     http://lists.otrs.org/cgi-bin/listinfo/dev     or, via email, send a message with subject or body 'help' to     dev-request@otrs.org

    You can reach the person managing the list at     dev-owner@otrs.org

    When replying, please edit your Subject line so it is more specific     than "Re: Contents of dev digest..."

    Today's Topics:

      1. Re: hello again every one Im back and have code to contribute          (Martin Gruner)

    ----------------------------------------------------------------------

    Message: 1     Date: Tue, 07 Jan 2014 10:45:42 +0100     From: Martin Gruner     Subject: Re: [dev] hello again every one Im back and have code to     contribute     To: Development community of OTRS     Message-ID: <52CBCCC6.5030506@otrs.com>     Content-Type: text/plain; charset=ISO-8859-1

    Hi Paul,

    great, looking very much forward to your pull requests.

    It is always good if the code does not change the behaviour (output),     but makes it more efficient etc., then it is most easy to integrate     for us.

    In case of the TemplateGenerator I would ask you to first write some     unit tests covering the current behaviour that you want to improve. This     is a module that does not have a good test coverage yet. Then apply your     optimizations and see if the unit tests still work correctly. Please see     scripts/test/TemplateGenerator/ for a very small example, or all the     other test cases in scripts/test. Test driven development is always     highly recommendable IMHO.

    Please let me know if you have any questions about the unit tests.

    Regards, mg

    Am 06.01.14 23:45, schrieb Paul Robert Marino:     > Carlos     > Thank you I'm already familiar with the guidelines since I was very     > active in the community back in 2006-8 when I maintained and developed     > an instance of OTRS for a stock exchange. That said I'll look it over to     > see if any thing other than the ability to submit via Github pull     > request has changed.     > You should expect to see some of my patches in the next couple of days.     > I hope people like them.     >     >     >     > -- Sent from my HP Pre3     >     > ------------------------------------------------------------------------     > On Jan 6, 2014 17:33, Carlos Rodr?guez wrote:     >     > Hi Paul,     >     > You as any other contributor is very welcome to send improvements in the     > code, thank you!     >     > As a suggestion please take a look at the OTRS Development Manual,     > specially in the code style guide     > http://doc.otrs.org/developer/3.3/en/html/code-style-guide.html     >     > Following this guide lines will make easier and faster to integrate your     > contributions.     >     > ((enjoy))     >     > Carlos Rodr?guez     >     >     >     >     > On Jan 6, 2014, at 4:05 PM, Paul Robert Marino mailto:prmarino1@gmail.com> wrote:     >     >> hello every one     >> Its been quite a few years since I was on this list. Im working now at     >> an other company where we are implementing OTRS. I have been looking     >> over the code and there has been a lot of progress since I last looked     >> at it.     >> That said there are a few things that struck me as inefficient and not     >> as flexible as I would like in Kernel/System/TemplateGenerator.pm     >>     >> Ill be signing the contributors agreement shortly and will do a fork     >> with a push request on github shortly but I wanted to gauge some of     >> the reactions to what I want to submit before I go to far with it.     >>     >> essentially what I would like to change is the handleing of tags like     >> and     >>     >> I found an inefficiency in the handling of     >> specificly if you set say     >> there is an     >> inefficiency in the loop which is easy to fix with a precheck which     >> I've already written.     >> additionally Ive also made a change where     >> are treated as inset the whole message.     >> the changes I made only added a few lines and a very slight     >> modification to the regex used to match and replace it.     >>     >> I also modified the handling  of to work     >> in a similar manner. and made it so if the length of the subject isn't     >> longer than the number of characters specified  it will not add the "     >> [...]" suffix to the subject.     >> this was handled by a slight tweak of the regex and the addition of an     >> if statement.     >>     >>     >> What I would like to do eventually is make this functionality a simple     >> set of methods (OO speak for functions) which can be called to handle     >> this for any of these template replace tags as efficiently as     >> possible. we would need more than two because of things like the     >> custom fields. I'm fairly sure I could be handled with just a few     >> methods simple to use methods and I could make the code far more     >> efficient in the process the data.     >>     >> Does any one have any comment, suggestions, or requests on this before     >> I get too deep into writing it?     >>     >> Thank You     >> Paul Robert Marino     >> _______________________________________________     >> OTRS mailing list: dev - Webpage: http://otrs.org/     >> Archive: http://lists.otrs.org/pipermail/dev     >> To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev     >>     >     >     >     > _______________________________________________     > OTRS mailing list: dev - Webpage: http://otrs.org/     > Archive: http://lists.otrs.org/pipermail/dev     > To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev     >

    --     Martin Gruner     Senior Developer R&D

    OTRS AG     Europaring 4     94315 Straubing

    T: +49 (0)6172 681988 0     F: +49 (0)9421 56818 18     I:  www.otrs.com/

    Gesch?ftssitz: Bad Homburg, Amtsgericht: Bad Homburg, HRB 10751,     USt-Nr.: DE256610065     Aufsichtsratsvorsitzender: Burchard Steinbild, Vorstand: Andr?     Mindermann (Vorsitzender), Christopher Kuhn, Sabine Riedel

    Einfache Planung, bessere ?bersicht - Mit OTRS 3.3 einfach besseres     Service Management - Jetzt downloaden und testen

    ------------------------------

    _______________________________________________     dev mailing list     dev@otrs.org     http://lists.otrs.org/cgi-bin/listinfo/dev

    End of dev Digest, Vol 34, Issue 5     **********************************

 

_______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev

-- Martin Gruner Senior Developer R&D OTRS AG Europaring 4 94315 Straubing T: +49 (0)6172 681988 0 F: +49 (0)9421 56818 18 I:  www.otrs.com/ Gesch?ftssitz: Bad Homburg, Amtsgericht: Bad Homburg, HRB 10751, USt-Nr.: DE256610065 Aufsichtsratsvorsitzender: Burchard Steinbild, Vorstand: Andr? Mindermann (Vorsitzender), Christopher Kuhn, Sabine Riedel Einfache Planung, bessere ?bersicht - Mit OTRS 3.3 einfach besseres Service Management - Jetzt downloaden und testen ------------------------------ Message: 2 Date: Mon, 13 Jan 2014 08:54:39 +0100 From: Martin Gruner Subject: Re: [dev] Upgrading password hashes To: Development community of OTRS Message-ID: <52D39BBF.8040806@otrs.com> Content-Type: text/plain; charset=ISO-8859-1 Hi Mike, that is a very good suggestion. Just make sure this fits into the architecture well. I'd check the string as it gets stored, not just the used algorithm. With bcrypt, for example, the cost parameter could change in future, so an update in the DB would also be needed. Please also provide unit tests for this. Thanks a lot in advance! Regards, mg Am 08.01.14 08:16, schrieb Michiel Beijen:

Hi all ;-)

I am really happy with the bcrypt password hashing mechanism that Martin and me added to OTRS 3.3.

That said, one thing that is not so nice is that passwords which already exists are not upgraded.

Of course, for upgrading we would need the plain password. So what we could do is, when a user logs in, compare the encryption mechanism of the password hash with the configured password mechanism in the configuration. If the mechanism is not the same, the pasword is set again but now with the new mechanism.

I created a small patch for this, does it sound sane? If so, I'll send a pull request with the code. -- Mike

_______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev

-- Martin Gruner Senior Developer R&D OTRS AG Europaring 4 94315 Straubing T: +49 (0)6172 681988 0 F: +49 (0)9421 56818 18 I:  www.otrs.com/ Gesch?ftssitz: Bad Homburg, Amtsgericht: Bad Homburg, HRB 10751, USt-Nr.: DE256610065 Aufsichtsratsvorsitzender: Burchard Steinbild, Vorstand: Andr? Mindermann (Vorsitzender), Christopher Kuhn, Sabine Riedel Einfache Planung, bessere ?bersicht - Mit OTRS 3.3 einfach besseres Service Management - Jetzt downloaden und testen ------------------------------ _______________________________________________ dev mailing list dev@otrs.org http://lists.otrs.org/cgi-bin/listinfo/dev End of dev Digest, Vol 34, Issue 8 **********************************