v1.3b4 bugs: charset hardwired and cosmetics in customer.pl

Hello, What do you prefer: bugs in the bugzilla or bugs here? :) Anyway, now here some. * customer.pl shows red $Quote{"} on the top when there is nothing to say ($Data{"Message"} is empty?) Okay, about charsets. I'm fighting with them since we don't use either 8859-1 (latin1) nor 8859-15 (latinEuro1). I'd like to use utf-8 as web charset (agent, customer) and 8859-2 for output email (due stupid stinky windows clients). Many modules use 8859-15 hardwired (egrep 8859-15 `find ~otrs/ -type f`) which is bad. Some patches against index.pl and cutomer.pl, and I hope I did get it right. I would rather have a DefaultCharset and DefaultEmailCharset, but for now I don't have the time to cross-check all the code. :( --- old/index.pl 2004-09-08 11:22:42.000000000 +0200 +++ index.pl 2004-09-08 11:25:00.000000000 +0200 @@ -428,7 +428,7 @@ if ($EmailObject->Send( To => $UserData{UserEmail}, Subject => $Subject, - Charset => 'iso-8859-15', + Charset => $CommonObject{ConfigObject}->Get('DefaultCharset'), Type => 'text/plain', Body => $Body)) { print $CommonObject{LayoutObject}->Login( --- old/customer.pl 2004-09-08 11:22:42.000000000 +0200 +++ customer.pl 2004-09-08 11:25:57.000000000 +0200 @@ -372,7 +372,7 @@ if ($EmailObject->Send( To => $UserData{UserEmail}, Subject => $Subject, - Charset => 'iso-8859-15', + Charset => $CommonObject{ConfigObject}->Get('DefaultCharset'), Type => 'text/plain', Body => $Body)) { print $CommonObject{LayoutObject}->CustomerLogin( @@ -447,7 +447,7 @@ if (!$EmailObject->Send( To => $GetParams{UserEmail}, Subject => $Subject, - Charset => 'iso-8859-15', + Charset => $CommonObject{ConfigObject}->Get('DefaultCharset'), Type => 'text/plain', Body => $Body)) { print $CommonObject{LayoutObject}->CustomerHeader(Area => 'Core', Title => 'Error'); -- Now using M2, Opera's e-mail client: http://www.opera.com/m2/
participants (1)
-
Peter Gervai