SendArticle.pm not using "Precedence"; fix included

I noticed that OTRS autoresponses don't include a "Precedence: bulk" header, even though the code tries to set one. This is because MIME::Entity doesn't consider "Precedence" a standard header for some reason (at least not in my vbersion 5.404), so it ignores it. This patch fixes it: *** SendArticle.pm.orig Sun Nov 30 22:09:41 2003 --- SendArticle.pm Sun Nov 30 22:11:50 2003 *************** *** 109,115 **** Encoding => '8bit', }; if ($Loop) { ! $$Header{Precedence} = 'bulk'; $$Header{'X-Loop'} = 'bulk'; } my $Entity = MIME::Entity->build(%{$Header}, Data => $Param{Body}); --- 109,118 ---- Encoding => '8bit', }; if ($Loop) { ! # the "Precedence" header isn't one of the standard MIME::Entity ! # headers, so it needs a trailing semicolon. See MIME::Entity ! # docs for "build". ! $$Header{'Precedence:'} = 'bulk'; $$Header{'X-Loop'} = 'bulk'; } my $Entity = MIME::Entity->build(%{$Header}, Data => $Param{Body}); Hope this helps. -- Robert L Mathews, Tiger Technologies http://www.tigertech.net/ "I am not able rightly to apprehend the kind of confusion of ideas that could provoke such a question." -- Charles Babbage

Hi Robert, thanks for your patch! I fixed it now! :) Thanks for your help! -Martini On Sun, Nov 30, 2003 at 10:26:10PM -0800, Robert L Mathews wrote:
I noticed that OTRS autoresponses don't include a "Precedence: bulk" header, even though the code tries to set one.
This is because MIME::Entity doesn't consider "Precedence" a standard header for some reason (at least not in my vbersion 5.404), so it ignores it.
This patch fixes it:
*** SendArticle.pm.orig Sun Nov 30 22:09:41 2003 --- SendArticle.pm Sun Nov 30 22:11:50 2003 *************** *** 109,115 **** Encoding => '8bit', }; if ($Loop) { ! $$Header{Precedence} = 'bulk'; $$Header{'X-Loop'} = 'bulk'; } my $Entity = MIME::Entity->build(%{$Header}, Data => $Param{Body}); --- 109,118 ---- Encoding => '8bit', }; if ($Loop) { ! # the "Precedence" header isn't one of the standard MIME::Entity ! # headers, so it needs a trailing semicolon. See MIME::Entity ! # docs for "build". ! $$Header{'Precedence:'} = 'bulk'; $$Header{'X-Loop'} = 'bulk'; } my $Entity = MIME::Entity->build(%{$Header}, Data => $Param{Body});
Hope this helps.
-- Robert L Mathews, Tiger Technologies http://www.tigertech.net/
"I am not able rightly to apprehend the kind of confusion of ideas that could provoke such a question." -- Charles Babbage
Martin Edenhofer -- ((otrs.de)) :: OTRS GmbH :: Norsk-Data-Str. 1 :: 61352 Bad Homburg http://www.otrs.de/ :: Manage your communication!
participants (2)
-
Martin Edenhofer
-
Robert L Mathews