At 10/27/04 11:02 PM, Martin Edenhofer wrote:

o Line Wrapping Bug in Browsers like Safari: Your patch is veriy fine. We just thinking about upcoming problems with other browsers. Anyway, if we remove the line wrapping from the html-tags, we have to change this in each <textarea> tags in the whole otrs. And this is the reason why we think a second time about.

I think there is a misunderstanding here. My patch only affects the AgentCompose and AgentSpelling screens; it does not make the code do any line wrapping in other places, so the other places need to have the wrap tags left in. In other words, the HTML wrap tags need to be removed from an HTML form if (and ONLY if) the OTRS code starts handling the wrapping for input from certain HTML forms. Since the code I provided only does this for AgentCompose and AgentSpelling, those are the only HTML pages that need the wrap tags removed. The wrap tags should not be removed from any other HTML pages that don't have new code added to handle wrapping in OTRS, unless extra code is also added to OTRS to handle wrapping for those pages. (I'd be glad to attempt adding OTRS code for other pages in the future so that all browser wrapping can be disabled -- it's evil -- but the current patch is just concerned with wrapping mail in replies sent to the customer. Incorrect wrapping in things like notes wasn't so important to me when I submitted the patch.) So as it stands, only those two pages need to have the wrap tags removed. I can't emphasize enough that having it the way it is for those two screens (both the HTML tags and the code doing independent wrapping) is very wrong, and makes OTRS replies into a nasty mess with browsers like Safari. Either the HTML tags should be removed, or the part of the patch that adds wrapping to the OTRS code should be backed out before the next release; having them both doing wrapping is never going to be right. I hope this clears it up! Thanks again. -- Robert L Mathews, Tiger Technologies http://www.tigertech.net/ "Ignorance more frequently begets confidence than does knowledge." -- Darwin