Bugs in TimeAccounting package (?)

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi otrs-dev, I've had a look the package TimeAccounting 1.0.1 and so far I've encountered some trouble. Apparently there are some bugs in the package. Maybe some of them only occur while using PostgreSQL (don't know about the tolerance of MySQL)... anyway, this is what I've figured out: (1) Kernel::System::TimeAccounting line 568: $Param{$_} = $Self->{DBObject}->Quote($Param{$_}) || ''; ...this is a problem when the value before the OR is 0 the assignment is evaluated to false and the empty string 'wins' the assignment. This causes trouble when inserting a NULL value into integer or numeric coloumns in DB-tables. Better would be something like that (IMO... at least it works for me ;)): $Param{$_} = $Self->{DBObject}->Quote($Param{$_}); if( !defined($Param{$_})) { $Param{$_} = ''; } The problem reappears in sub UserSettingsUpdate. (2) Kernel::System::TimeAccounting line 595 and following: the column 'DESCRIPTION' which is set to NOT NULL, is ommited. This statement is not accepted by the data base. The initial configuration doesn'T allow to give a description anyway. So my workaround is => use of a default user description for the initial insert => and (of course) completion of the SQL-statement in line 595 (3) Kernel::Modules::AgentTimeAccounting 245: $Data{$WorkingUnitID}{Period} = ''; ...better would be: $Data{$WorkingUnitID}{Period} = 'NULL'; I'd have created an entry in bugs.otrs.org if there was an option for the TimeAccounting module. So I just put it here :) regards, Torsten Thau - -- Torsten Thau, Dipl. Inform. c.a.p.e. IT Labs GbR - Annaberger Str. 240 - D-09125 Chemnitz phone: +49 371 5347 623 cell: +49 176 66 680 680 pgp-key: 0x292F987D fax: +49 371 5347 625 http://www.cape-it.de -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFGVEfgvXo8m5PgoXQRAttgAJsFxDrQedhDJYrwXLYvGa+v/p2eqACeOZLH 4z0X30CzQA/7M/b1LrAz1d8= =QgwY -----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 ...appart from the fact, that the time accounting package isn't available for download anymore, one more hint: Kernel::Output::HTML::NotificationTimeAccounting is missing return values in case there's no $IncompleteWorkingDays{Warning}. Otherwise there's an unaesthetic "Use of uninitialized value in concatenation" :) regards, Torsten Thau - -- Torsten Thau, Dipl. Inform. c.a.p.e. IT Labs GbR - Annaberger Str. 240 - D-09125 Chemnitz phone: +49 371 5347 623 cell: +49 176 66 680 680 pgp-key: 0x292F987D fax: +49 371 5347 625 http://www.cape-it.de -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFGVYBgvXo8m5PgoXQRAvuXAJ4rc2nPOcNFT1z00pTMprE02OhDngCfXGrk XtU6hVCHaFEhDY/4Rd3vKf0= =Q36p -----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Torsten, Your feedback is very detailed. Thanks for that. At the end of the next week I have time to handle your suggestions. Do you have TimeAccounting files which you can send me? Especially a de-translation file? Thanks for your mail. Thomas Torsten Thau wrote:
...appart from the fact, that the time accounting package isn't available for download anymore, one more hint:
Kernel::Output::HTML::NotificationTimeAccounting is missing return values in case there's no $IncompleteWorkingDays{Warning}. Otherwise there's an unaesthetic "Use of uninitialized value in concatenation" :)
regards, Torsten Thau
_______________________________________________ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFGVYm55VEHpl41kC8RAnlNAKDdCul6zIppy1dW/n4eJpgrjjNJKgCg0GQx EZGRphZT5xA1iKa/5BcWjfA= =yjW0 -----END PGP SIGNATURE-----
participants (2)
-
Thomas Raith
-
Torsten Thau