Hi Robert, thanks for info. I added the patch (also in 1.2). -Martin On Mon, Feb 09, 2004 at 04:19:32PM -0800, Robert L Mathews wrote:

I noticed that ArticleStorageFS::DeleteArticleOfTicket() leaves behind empty directories where a ticket used to be. If you're using the GenericAgent to actually delete tickets because they're spam, etc., this leaves behind lots of empty directories.

Assuming this isn't intentional for some reason, here is a trivial patch:

diff -c ArticleStorageFS.pm.orig ArticleStorageFS.pm *** ArticleStorageFS.pm.orig Sat Jan 10 07:32:47 2004 --- ArticleStorageFS.pm Mon Feb 9 16:03:03 2004 *************** *** 94,100 **** $Self->{DBObject}->Do(SQL => "DELETE FROM article_plain WHERE article_id = $_"); # delete from fs my $ContentPath = $Self->GetArticleContentPath(ArticleID => $_); ! system("rm -rf $Self->{ArticleDataDir}/$ContentPath/$_/*"); } # -- # delete articles --- 94,100 ---- $Self->{DBObject}->Do(SQL => "DELETE FROM article_plain WHERE article_id = $_"); # delete from fs my $ContentPath = $Self->GetArticleContentPath(ArticleID => $_); ! system("rm -rf $Self->{ArticleDataDir}/$ContentPath/$_"); } # -- # delete articles

-- Robert L Mathews, Tiger Technologies http://www.tigertech.net/

"Ignorance more frequently begets confidence than does knowledge." -- Darwin

Martin Edenhofer -- ((otrs.de)) :: OTRS GmbH :: Norsk-Data-Str. 1 :: 61352 Bad Homburg http://www.otrs.de/ :: Manage your communication!