So here are the diffs...
Hi,
I programmed an add-on for the FAQ-Section. In our System it is now possible to add Attachments to FAQ-articles.
The attachments are stored in ~/var/httpd/htdocs/otrs_faq (configurable in Config.pm $Self->{FAQDirectory}). For each FAQ-article there is a subdirectory which name is the ID of the FAQ-article. When you view an article, Perl checks if there are any files in the corresponding directory and creates links to these files. You can then directly download the files from Apache (no "passthrough" with perl). I know this may be a security problem, because OTRS has no access control over these files (everyone who can guess the filename and path can download the file).
Files/Directories affected from my changes (changed or added): ./Kernel/Config.pm (2 new Config-Settings) # Path in the filesystem where Attachments are stored $Self->{FAQDirectory} = '/opt/otrs/var/httpd/htdocs/otrs_faq/'; # "Path in the Browser" $Self->{FAQWebPath} = '/otrs-web/otrs_faq/'; ./Kernel/Modules/FAQArticle.pm (added Upload-Functionality) ./Kernel/Output/HTML/xyz/FAQArticleForm.dtl (Upload-Input-field, Upload delete) ./Kernel/Output/HTML/xyz/FAQArticleView.dtl (Upload-Links) ./Kernel/System/FAQ.pm ./Kernel/System/FAQ/ArticleStorageFS.pm (new module,Write Upload to FS) ./var/httpd/htdocs/otrs_faq/ (directory where attachments are saved) I attached the diffs to this email. Diffs where made against OTRS 1.3 beta 1 with diff orig_file modified_file > file.diff I hope you people can cope with that :-) Volker
Hi Volker, thanks for the patch. It's not possible to put it into OTRS 1.3. But OTRS 2.0 will have the attachment support. Thanks for your really good work Volker! Martin -- ((otrs.de)) :: OTRS GmbH :: Norsk-Data-Str. 1 :: 61352 Bad Homburg http://www.otrs.de/ :: Manage your communication! On Thu, Aug 19, 2004 at 04:37:49PM +0200, Volker Maibaum wrote:
So here are the diffs...
Hi,
I programmed an add-on for the FAQ-Section. In our System it is now possible to add Attachments to FAQ-articles.
The attachments are stored in ~/var/httpd/htdocs/otrs_faq (configurable in Config.pm $Self->{FAQDirectory}). For each FAQ-article there is a subdirectory which name is the ID of the FAQ-article. When you view an article, Perl checks if there are any files in the corresponding directory and creates links to these files. You can then directly download the files from Apache (no "passthrough" with perl). I know this may be a security problem, because OTRS has no access control over these files (everyone who can guess the filename and path can download the file).
Files/Directories affected from my changes (changed or added): ./Kernel/Config.pm (2 new Config-Settings) # Path in the filesystem where Attachments are stored $Self->{FAQDirectory} = '/opt/otrs/var/httpd/htdocs/otrs_faq/'; # "Path in the Browser" $Self->{FAQWebPath} = '/otrs-web/otrs_faq/';
./Kernel/Modules/FAQArticle.pm (added Upload-Functionality) ./Kernel/Output/HTML/xyz/FAQArticleForm.dtl (Upload-Input-field, Upload delete) ./Kernel/Output/HTML/xyz/FAQArticleView.dtl (Upload-Links) ./Kernel/System/FAQ.pm ./Kernel/System/FAQ/ArticleStorageFS.pm (new module,Write Upload to FS) ./var/httpd/htdocs/otrs_faq/ (directory where attachments are saved)
I attached the diffs to this email. Diffs where made against OTRS 1.3 beta 1 with diff orig_file modified_file > file.diff
I hope you people can cope with that :-)
Volker
Hallo, thanks, but unfortunately here comes the first patch for the first bug in ...System/FAQ/ArticleStorageFS.pm :-( Problem: When trying to delete an Article without attachment, an error is raised. Patch: 95d94 < if (!-e $DIRNAME) { return 1;} regards, Volker Am Mi, den 25.08.2004 schrieb Martin Edenhofer um 10:17:
Hi Volker,
thanks for the patch. It's not possible to put it into OTRS 1.3. But OTRS 2.0 will have the attachment support.
Thanks for your really good work Volker!
Martin
-- ((otrs.de)) :: OTRS GmbH :: Norsk-Data-Str. 1 :: 61352 Bad Homburg http://www.otrs.de/ :: Manage your communication!
On Thu, Aug 19, 2004 at 04:37:49PM +0200, Volker Maibaum wrote:
So here are the diffs...
Hi,
I programmed an add-on for the FAQ-Section. In our System it is now possible to add Attachments to FAQ-articles.
The attachments are stored in ~/var/httpd/htdocs/otrs_faq (configurable in Config.pm $Self->{FAQDirectory}). For each FAQ-article there is a subdirectory which name is the ID of the FAQ-article. When you view an article, Perl checks if there are any files in the corresponding directory and creates links to these files. You can then directly download the files from Apache (no "passthrough" with perl). I know this may be a security problem, because OTRS has no access control over these files (everyone who can guess the filename and path can download the file).
Files/Directories affected from my changes (changed or added): ./Kernel/Config.pm (2 new Config-Settings) # Path in the filesystem where Attachments are stored $Self->{FAQDirectory} = '/opt/otrs/var/httpd/htdocs/otrs_faq/'; # "Path in the Browser" $Self->{FAQWebPath} = '/otrs-web/otrs_faq/';
./Kernel/Modules/FAQArticle.pm (added Upload-Functionality) ./Kernel/Output/HTML/xyz/FAQArticleForm.dtl (Upload-Input-field, Upload delete) ./Kernel/Output/HTML/xyz/FAQArticleView.dtl (Upload-Links) ./Kernel/System/FAQ.pm ./Kernel/System/FAQ/ArticleStorageFS.pm (new module,Write Upload to FS) ./var/httpd/htdocs/otrs_faq/ (directory where attachments are saved)
I attached the diffs to this email. Diffs where made against OTRS 1.3 beta 1 with diff orig_file modified_file > file.diff
I hope you people can cope with that :-)
Volker
_______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
participants (2)
-
Martin Edenhofer -
Volker Maibaum