Hi, I programmed an add-on for the FAQ-Section. In our System it is now possible to add Attachments to FAQ-articles. The attachments are stored in ~/var/httpd/htdocs/otrs_faq (configurable in Config.pm $Self->{FAQDirectory}). For each FAQ-article there is a subdirectory which name is the ID of the FAQ-article. When you view an article, Perl checks if there are any files in the corresponding directory and creates links to these files. You can then directly download the files from Apache (no "passthrough" with perl). I know this may be a security problem, because OTRS has no access control over these files (everyone who can guess the filename and path can download the file). Files/Directories affected from my changes (changed or added): ./Kernel/Config.pm (2 new Config-Settings) ./Kernel/Modules/FAQArticle.pm (added Upload-Functionality) ./Kernel/Output/HTML/xyz/FAQArticleForm.dtl (Upload-Input-field, Upload delete) ./Kernel/Output/HTML/xyz/FAQArticleView.dtl (Upload-Links) ./Kernel/System/FAQ.pm ./Kernel/System/FAQ/ArticleStorageFS.pm (new module,Write Upload to FS) ./var/httpd/htdocs/otrs_faq/ (directory where attachments are saved) Do you think it would make sense to put this functionality into future releases? regards, Volker
Hello Volker, I think this is a good feature. Did you also include this directory into the backup.sh script ? I think this would be important too. Another thing is that it may be good to place the files into the Database, so everything is in the database and not scattered around the fs, but that is just my opinion :) Bye, Robert Volker Maibaum wrote:
Do you think it would make sense to put this functionality into future releases?
regards,
Volker
Hi Robert, as I'm still a beginner what concerns Perl and I only know the basics, I have choosen the most simple way and that was putting the files in the fs. Besides we also have our Tickets stored in the fs and therefore the otrs data is not in one place anyway. As many others, I am not familiar with CVS and in addition to this I am behind a firewall which probably doesn't allow the access to your cvs-System. So I'm not sure how to provide the Code in a proper way. If someone knows a good way, I will work the Code over again to make it fit to the quality of the rest of the otrs code. regards, Volker Am Mi, den 07.07.2004 schrieb Robert Heinzmann um 19:07:
Hello Volker,
I think this is a good feature. Did you also include this directory into the backup.sh script ? I think this would be important too.
Another thing is that it may be good to place the files into the Database, so everything is in the database and not scattered around the fs, but that is just my opinion :)
Bye,
Robert
Volker Maibaum wrote:
Do you think it would make sense to put this functionality into future releases?
regards,
Volker
_______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
Hello Volker, please do not mistake me with Robert Kehl (which comes from OTRS) :). I'm not a developer of OTRS, just a user, so CVS is out of my scope. I just wanted to add comments and emphasize that this is a good feature, especially if you use the old tickets as basis to find solutions for problems faster and identify known problems with their corresponding solution (problem lifecycle). Bye Robert Heinzman Volker Maibaum wrote:
Hi Robert,
as I'm still a beginner what concerns Perl and I only know the basics, I have choosen the most simple way and that was putting the files in the fs. Besides we also have our Tickets stored in the fs and therefore the otrs data is not in one place anyway.
As many others, I am not familiar with CVS and in addition to this I am behind a firewall which probably doesn't allow the access to your cvs-System. So I'm not sure how to provide the Code in a proper way.
If someone knows a good way, I will work the Code over again to make it fit to the quality of the rest of the otrs code.
regards,
Volker
Hi Volker, On Wed, Jul 07, 2004 at 02:22:35PM +0200, Volker Maibaum wrote:
I programmed an add-on for the FAQ-Section. In our System it is now possible to add Attachments to FAQ-articles. [...] Do you think it would make sense to put this functionality into future releases?
Of course! :) Post the patch on the list an we will add this feature to the cvs. Thanks for your help!
Volker
Martin -- ((otrs.de)) :: OTRS GmbH :: Norsk-Data-Str. 1 :: 61352 Bad Homburg http://www.otrs.de/ :: Manage your communication!
participants (3)
-
Martin Edenhofer -
Robert Heinzmann -
Volker Maibaum