diff -Nru -x var/ /opt/OpenTRS/Kernel/Output/HTML/Agent.pm ./Kernel/Output/HTML/Agent.pm --- /opt/OpenTRS/Kernel/Output/HTML/Agent.pm Sun Jun 9 18:54:38 2002 +++ ./Kernel/Output/HTML/Agent.pm Thu Jun 6 00:55:34 2002 @@ -58,19 +58,15 @@ $QueueStrg .= "<font color='$Self->{HighlightColor1}'>"; } # the oldest queue - if ($QueueIDOfMaxAge !~ /[?]/) { - if ($Queue{QueueID} == $QueueIDOfMaxAge) { - $QueueStrg .= "<blink>"; - } - } + if ($Queue{QueueID} == $QueueIDOfMaxAge) { + $QueueStrg .= "<blink>"; + } # QueueStrg $QueueStrg .= "$Queue{Queue} ($Queue{Count})"; - if ($QueueIDOfMaxAge !~ /[?]/) { - # the oldest queue - if ($Queue{QueueID} == $QueueIDOfMaxAge) { - $QueueStrg .= "</blink>"; - } - } + # the oldest queue + if ($Queue{QueueID} == $QueueIDOfMaxAge) { + $QueueStrg .= "</blink>"; + } # should i highlight this queue if ($Queue{MaxAge} >= $Self->{HighlightAge1} || $Queue{MaxAge} >= $Self->{HighlightAge2}) { -- Pablo Ruiz Garcia (Pci) Consultor de Seguridad - Tiger Team IP6 Seguridad (pruiz@ip6seguridad.com) http://www.ip6seguridad.com/pgp/pruiz.asc
Hi Pablo, On Mon, Jun 10, 2002 at 06:07:36PM +0200, Pablo Ruiz Garcia wrote:
diff -Nru -x var/ /opt/OpenTRS/Kernel/Output/HTML/Agent.pm ./Kernel/Output/HTML/Agent.pm --- /opt/OpenTRS/Kernel/Output/HTML/Agent.pm Sun Jun 9 18:54:38 2002 +++ ./Kernel/Output/HTML/Agent.pm Thu Jun 6 00:55:34 2002 @@ -58,19 +58,15 @@ $QueueStrg .= "<font color='$Self->{HighlightColor1}'>"; } # the oldest queue - if ($QueueIDOfMaxAge !~ /[?]/) { - if ($Queue{QueueID} == $QueueIDOfMaxAge) { - $QueueStrg .= "<blink>"; - } - } [...]
I can't follow your thoughts. |-/ Can you explain it? Thanks.
-- Pablo Ruiz Garcia (Pci)
Martin -- Martin Edenhofer - <martin at edenhofer.de> - http://martin.edenhofer.de/ -- Old programmers never die. They just branch to a new address.
Hi,
On Agent.pm at line 41 $QueueIDOfMaxAge (if not defined
$Param{QueueIDOfMaxAge}) gots
the value "?", which isn't numeric value, so when the comparision indicated on
my patch occurs
i got an error..
What is $Param{QueueIDOfMaxAge} for?
;)
--
Pablo Ruiz Garcia (Pci)
Consultor de Seguridad - Tiger Team
IP6 Seguridad (pruiz@ip6seguridad.com)
http://www.ip6seguridad.com/pgp/pruiz.asc
----- Original Message -----
From: "Martin Edenhofer"
Hi Pablo,
On Mon, Jun 10, 2002 at 06:07:36PM +0200, Pablo Ruiz Garcia wrote:
diff -Nru -x var/ /opt/OpenTRS/Kernel/Output/HTML/Agent.pm ./Kernel/Output/HTML/Agent.pm --- /opt/OpenTRS/Kernel/Output/HTML/Agent.pm Sun Jun 9 18:54:38 2002 +++ ./Kernel/Output/HTML/Agent.pm Thu Jun 6 00:55:34 2002 @@ -58,19 +58,15 @@ $QueueStrg .= "<font color='$Self->{HighlightColor1}'>"; } # the oldest queue - if ($QueueIDOfMaxAge !~ /[?]/) { - if ($Queue{QueueID} == $QueueIDOfMaxAge) { - $QueueStrg .= "<blink>"; - } - } [...]
I can't follow your thoughts. |-/ Can you explain it? Thanks.
-- Pablo Ruiz Garcia (Pci)
Martin
-- Martin Edenhofer - <martin at edenhofer.de> - http://martin.edenhofer.de/ -- Old programmers never die. They just branch to a new address.
_______________________________________________ OpenTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
Hi Pablo, On Fri, Jun 14, 2002 at 07:35:17PM +0200, Pablo Ruiz Garcia wrote:
On Agent.pm at line 41 $QueueIDOfMaxAge (if not defined $Param{QueueIDOfMaxAge}) gots the value "?", which isn't numeric value, so when the comparision indicated on my patch occurs i got an error..
Now! ;) Thanks. I fixed it in the CVS.
What is $Param{QueueIDOfMaxAge} for? ;)
This is for the queue with the oldest ticket. So Agent.pm->QueueView() can highlight this queue.
-- Pablo Ruiz Garcia (Pci)
Martin -- Martin Edenhofer - <martin at edenhofer.de> - http://martin.edenhofer.de/ -- Perfection is our goal, excellence will be tolerated. -- J. Yahl
participants (2)
-
Martin Edenhofer -
Pablo Ruiz Garcia