Re: [dev] Re: message hard wrapping

Does anyone have any thoughts on my message about wrapping from a couple of days ago? As I mentioned, on my copy of OTRS, I made changes to remove the hard browser wrapping and have OTRS handle it internally using those nifty regexps that wrap at 75 characters or less (rather than 75 characters or more, as in the current scheme). So far, so good -- it has solved all my wrapping problems, especially with quoting a customer's reply. It has been tested on several hundred tickets, including some weird ones I created intentionally to try to break it. Again, I would like to submit a patch for this if it would be accepted. However, it involves modifying quite a few templates to remove browser hard wrapping (because the two wrapping methods conflict with each other). Does anyone know of a reason that the hard wrapping in the templates exists, other than the fact that OTRS couldn't handle the wrapping the itself? In other words, if OTRS correctly handled line wrapping, is there any reason to keep it? If nobody knows of a reason why the hard wrapping is needed, Martin, would a patch that replaces it be likely to be accepted? -- Robert L Mathews, Tiger Technologies http://www.tigertech.net/ "Ignorance more frequently begets confidence than does knowledge." -- Darwin

On 20-04-2004 at 15:24, Robert L Mathews wrote:
Does anyone have any thoughts on my message about wrapping from a couple of days ago?
I'm going to test your patch on our production system. Two questions anyway: 1. Did you fix the issue with original messages being wrapped at more than $NewLine characters? If I'm not wrong, Outlook's default is 80 characters. 2. How do your regexp'es handle long URLs? They shouldn't wrap lines containing a single word (actually, they shouldn't wrap words at all). I'm currently using Text::Wrap to do wrapping, and this works great (also with long URLs), except for quoted text which is badly wrapped. Anyway, I think that good message wrapping should be integrated in OTRS as soon as possible. --Alessandro.
participants (2)
-
Alessandro Ranellucci
-
Robert L Mathews