Hi, (I was told this was a better list to post to, not the standard OTRS list) In looking closer at the code, I see some places where the system throws an : $Self->{LogObject}->Log( Message => 'Something here', Priority => 'error', ); but then goes about its business as if nothing REALLY was wrong. The one that is of biggest concern at the current moment is : Kernel/Output/HTML/PreferencesCustomQueue.pm, sub Param, where it says : # check needed param if (!$Param{UserData}->{UserID}) { $Self->{LogObject}->Log(Priority => 'error', Message => "Need UserID!"); return (); } It appears that it *ALWAYS* prints it when your doing an : <form action="/otrs/index.pl" method="post"> <input type="hidden" name="Action" value="AdminUser"> <input type="hidden" name="Subaction" value="Add"> so is it *REALLY* an error. It appears to throw this into the Apache error log every time I attempt to add an Admin User. I do see plenty of others that do seem like they are TRUE and LEGIT errors, but certainly not this one. I would think the best thing to do is just remove the Log completely there, unless there is a reason it should always just throw everything into my Apache logs and then go about its business.... Thanks, Tuc
Hi Tuc, On Nov 6, 2007, at 1:34 AM, Tuc at T-B-O-H.NET wrote:
(I was told this was a better list to post to, not the standard OTRS list)
In looking closer at the code, I see some places where the system throws an :
$Self->{LogObject}->Log( Message => 'Something here', Priority => 'error', );
but then goes about its business as if nothing REALLY was wrong. The one that is of biggest concern at the current moment is :
Kernel/Output/HTML/PreferencesCustomQueue.pm, sub Param, where it says :
# check needed param if (!$Param{UserData}->{UserID}) { $Self->{LogObject}->Log(Priority => 'error', Message => "Need UserID!"); return (); }
It appears that it *ALWAYS* prints it when your doing an :
<form action="/otrs/index.pl" method="post"> <input type="hidden" name="Action" value="AdminUser"> <input type="hidden" name="Subaction" value="Add">
so is it *REALLY* an error. It appears to throw this into the Apache error log every time I attempt to add an Admin User.
Normally it shout not appear if you go into the admin user mask. So I think it's a bug (but it's working fine on my installations %-)). It would be nice if the problem would be reproducible to finde the problem. -=> So can you reproduce this on a fresh installed OTRS (only default settings). Did you some customizing on OTRS? Greetings, -Martin -- ((otrs)) :: OTRS AG :: Europaring 4 :: D - 94315 Straubing Fon: +49 (0) 9421 56818 0 :: Fax: +49 (0) 9421 56818 18 http://www.otrs.com/ :: Communication with success! Address of record: Bad Homburg Local Court: Bad Homburg, HRB 10751 Tax number: 003/240/97521 Chairman: Burchard Steinbild Chief Executive Officer: André Mindermann
It appears that it *ALWAYS* prints it when your doing an :
<form action="/otrs/index.pl" method="post"> <input type="hidden" name="Action" value="AdminUser"> <input type="hidden" name="Subaction" value="Add">
so is it *REALLY* an error. It appears to throw this into the Apache error log every time I attempt to add an Admin User.
Normally it shout not appear if you go into the admin user mask.
So I think it's a bug (but it's working fine on my installations %-)).
I had filed http://bugs.otrs.org/show_bug.cgi?id=2411 on it.
It would be nice if the problem would be reproducible to finde the problem.
-=> So can you reproduce this on a fresh installed OTRS (only default settings). Did you some customizing on OTRS?
I found out why I saw it and pretty much no one else in the entire world did. :) While it seems that OTRS does try to keep security in mind, I'm not very trusting. I used something called CGIWRAP to make sure more stringent security was in place. One of the things it didn't like is that index.pl was 777, so I made it 755 for it to run. One of the features of CGIWRAP (Currently at 4.0) is that if there is any STDERR printed, it DEFAULTS to also putting it into the STDOUT stream. In the 8 or 9 years I've been using it no application ever did that which is why I didn't understand or look for that happening when I first encountered the error. One of the config options IS to keep the STDERR *OUT* of the STDOUT, which is normal for a typical basic install of any CGI onto Apache. So, in the interim, I did compile a special CGIWRAP just for OTRS and now I have things working. It apparently will happen to everyone else in the entire world, except since they aren't sending it to the screen like CGIWRAP does, they won't realize it. So on a base install, its happening that it logs the error, but just goes along its merry way. It still leads me to ask, though, if error messages like that are actually REALLY errors that should have that happen. I do see others that *ARE* true errors, and I can see putting them into the logs... But wondered if there was a better way to do it than just sending to STDERR? I usually log my CGI's to a file, so I've never worked with putting them into the ErrorLog directive. I really appreciate this, and now that the system is actually usable (Since we can add non root@localhost users) I hope to become more active in contributing. Thanks, Tuc
Hi Tu, On Nov 7, 2007, at 5:21 PM, Tuc at T-B-O-H.NET wrote:
It appears that it *ALWAYS* prints it when your doing an :
<form action="/otrs/index.pl" method="post"> <input type="hidden" name="Action" value="AdminUser"> <input type="hidden" name="Subaction" value="Add">
so is it *REALLY* an error. It appears to throw this into the Apache error log every time I attempt to add an Admin User.
Normally it shout not appear if you go into the admin user mask.
So I think it's a bug (but it's working fine on my installations %-)).
I had filed http://bugs.otrs.org/show_bug.cgi?id=2411 on it.
Thanks. No I got it. The entry is updated.
It would be nice if the problem would be reproducible to finde the problem.
-=> So can you reproduce this on a fresh installed OTRS (only default settings). Did you some customizing on OTRS?
I found out why I saw it and pretty much no one else in the entire world did. :) [...] It still leads me to ask, though, if error messages like that are actually REALLY errors that should have that happen. I do see others that *ARE* true errors, and I can see putting them into the logs... But wondered if there was a better way to do it than just sending to STDERR? I usually log my CGI's to a file, so I've never worked with putting them into the ErrorLog directive.
I really appreciate this, and now that the system is actually usable (Since we can add non root@localhost users) I hope to become more active in contributing.
No, it's not really an error message (and it will not exit any longer :) ). See my latest email or the bug entry. -Martin -- ((otrs)) :: OTRS AG :: Europaring 4 :: D - 94315 Straubing Fon: +49 (0) 9421 56818 0 :: Fax: +49 (0) 9421 56818 18 http://www.otrs.com/ :: Communication with success! Address of record: Bad Homburg Local Court: Bad Homburg, HRB 10751 Tax number: 003/240/97521 Chairman: Burchard Steinbild Chief Executive Officer: André Mindermann
participants (2)
-
Martin Edenhofer -
Tuc at T-B-O-H.NET