Re: [otrs] TicketDivider is not working with 1.3.0 beta 3

At 9/9/04 12:36 PM, "Robert Kehl"
patching file Kernel/Modules/AgentForward.pm Hunk #1 succeeded at 15 with fuzz 1. Hunk #2 succeeded at 165 (offset -6 lines). ... patching file Kernel/System/Ticket/Article.pm Hunk #1 succeeded at 15 with fuzz 1. Hunk #2 succeeded at 1688 (offset 20 lines). Hunk #3 succeeded at 1866 (offset 20 lines). Hunk #4 succeeded at 2028 (offset 20 lines). Hunk #5 succeeded at 2049 (offset 20 lines).
This is against an up-to-date CVS rel-1_3.
As a followup, I did try this and looked at the files in question, and the patches did apply properly anyway, so it should be okay. Hope this helps. -- Robert L Mathews, Tiger Technologies http://www.tigertech.net/ "Ignorance more frequently begets confidence than does knowledge." -- Darwin

On Friday, September 10, 2004 12:05 AM
Robert L Mathews
At 9/9/04 12:36 PM, "Robert Kehl"
wrote: This is against an up-to-date CVS rel-1_3.
As a followup, I did try this and looked at the files in question, and the patches did apply properly anyway, so it should be okay.
Yesyesyes, that's what I meant - we're on go. It's the logic of 'patch' that saves us here, once again Larry Wall's work - bow, bow, bow. With kind regards, Robert Kehl

On Friday, September 10, 2004 3:30 AM
Robert Kehl
Yesyesyes, that's what I meant - we're on go. It's the logic of 'patch' that saves us here, once again Larry Wall's work - bow, bow, bow.
Btw, in Kernel/System/EmailSubject.pm I changed lines 214ff. to not default to 'Re: ', as it seems to not allow the empty string set in Config.pm: if ($Param{Re}) { $Param{Subject} = ($Self->{ConfigObject}->Get('SubjectRe') || '') . $Param{Subject}; } This way, the (old) setting of using 'Re: ' from Defaults.pm becomes active, even if we don't set it in Config.pm. But we are allowed to set the empty string, too. Great work! Hopefully, Martin implements it. With kind regards, Robert Kehl -- Zwei Chancen, ein Tor - das nenne ich hundertprozentige Chancenauswertung! Roland Wohlfahrt
participants (2)
-
Robert Kehl
-
Robert L Mathews