February 2016 - dev - OTRS mailing lists

Why is there a "new" and "run" in every module?
by Niels Dimmers 29 Feb '16

29 Feb '16

Hi, In an attempt to fix bug 8104 I am restructuring a lot of code in the module AgentTicketZoom and the related toolbar packages (located in Kernel/Output/HTML/ToolBar). I found that there's a "new" and "run" sub in the module and in the display packages as well. Does anyone know why this structure has been chosen? Isn't it far easier to use (get) and (set) methods to get and set data? I think it should be easier to let the model (Kernel/Output/HTML/ToolBar) generate and/or supply the template, instead of doing this partly in the contoller (AgentTicketZoom) and the template. I think the way it's structured now requires a lot of extra code and a lot of processing power whilst the same could be dealt with easier and cheaper. Do you have any suggestions on this? Since it is *a lot* of work I thought about mailing you first before applying such a broad restructure of the code. Regards, Niels

2 1

Linking expansion modules
by Juan Manuel Clavero Almirón 22 Feb '16

22 Feb '16

Hi all, I'm about to engage in the custom-code migration from OTRS 3.1 to OTRS 5. I've been reading the developers manual and I'm intrigued by the module-tools/link.pl script. As I understand it, its purpose is to replace the Kernel modules by the custom ones. Is it so? If this is correct, then I do not need to link if I'm using the Custom folder, right? Or is the Custom folder no longer supported in OTRS 5? I haven't found any reference in the manual. Kind regards, Juan Clavero

2 1

Strange behavior in layout output
by Finetti, Stefano 19 Feb '16

19 Feb '16

Greetings to everyone, I posted this message in the general otrs list but I think that the dev list is more appropriate for this kind of questions. Let me know if I'm wrong, please. I must confess I'm a bit lost with something that never happened before with other customizations I've done in OTRS. I'm trying to create a module for OTRS 4 to help my colleagues work with our AS400 systems. Nothing very strange, just a new menu to be used to check various informations about the systems. I'm not completely new to OTRS customizations, and I've managed to create some custom module using LayoutObject, DBObject and so. This is not a code problem, or at least, not an easy one to spot. When I access the page I created, I got the output correctly formatted from the query I run on an external DB, and, - and this is the problem - a long string just below the navigation menu containing a sequence of numbers, that I've identified with the number of records that my queries get. The absolutely strange thing is that I didn't put ANY print, echo or something like that in the code, and that all the output is directed through LayoutObject->Block with name and data. The template files has the correct names for RenderBlockStart and Stop and [% Data.Variables | html %] Section. In fact, inside the RenderBlocks all the output is fine. Since it's quite difficult even to explain the problem, I made a screenshot of what I'm talking about. [image: Immagine incorporata 1] I've filtered out the output for privacy, but here is the strange output just below "Dashboard". I'm not using any customized layout (i.e. no .pm files in Output/HTML/, only .tt files in Output/HTML/Standard/). This has been haunting me for days now, without any luck. I might also add that those numbers are inserted between two <div> apparently outside from normal HTML code: *<div id="NavigationContainer" data-original-width="98%">* *<ul id="Navigation" class="Draggable ARIARoleNavigation ui-sortable" style="visibility: visible; left: 0px; width: 593px; right: auto; display: block;" role="navigation">* *</div>* *1234567891011121314151617181920* *<div class="MainBox AriaRoleMain LayoutFixedSidebar SidebarFirst">* As you can see, the first div is the NavigationContainer (the OTRS Menu), while the last is the MainBox container, which is used in OTRS to generate the "main" contents page. (The numbers are a sequence: 1 2 3 4 5 6 7 8 9 10 11 12 etc. etc.) -- *Lynx International Srl* *Stefano Finetti* *http://www.lynx-international.com <http://www.lynx-international.com>* *Lynx International Srl is a part of AXED Group* Via Pier Luigi Nervi e/3 - Torre 6 - 04100 Latina -- This e-mail and any files transmitted contain documentation which is highly confidential and intended solely for the use of the individual or entity to whom they are addressed. All written data and other information in the documentation is and shall remain the property of the disclosing party. If you are not the intended recipient you are hereby formally notified that any disclosure, dissemination, forwarding, storing, copying or use of any of the information is strictly prohibited and will be legally pursued. If you received this in error, please contact the sender and destroy the documentation including deletion of the same from any computer. Thank you.

2 2